On Mar 18, 11:56 pm, "Nicolas M. Thiery" <nicolas.thi...@u-psud.fr> wrote: > > On the subject of pickling I just found out the hard way that the pickle jar > > is no longer tested by default, since trac_10712, which was merged in 4.6.2 > > marks the following test in sage_object.pyx long time that tests the > > pickle jar. > > > - sage: print "x"; sage.structure.sage_object.unpickle_all() > > + sage: print "x"; sage.structure.sage_object.unpickle_all() # long time > > (4s on sage.math, 2011)
I was the reviewer on that ticket. Mea culpa. The review was requested on sage-devel, so there was a small amount of public warning. I believe Jeroen, as release manager, always runs long tests, and I too have gotten in the habit of doing the same when I test something potentially invasive, or test a new alpha. Not an excuse, but on faster machines, I don't think the long tests really take all that much longer (about 30% longer if I remember right from testing this patch). So long tests don't have to be the "default" in practice. And I know there are folks with hardware that limits testing time, which may have been the rationale for marking off a slew of longer tests. > Unless someone expresses a strong counter-feeling by Monday, I'll > post a patch to revert that. I don't think a reversing-patch on this test would be at all controversial and certainly others could look at #10712 if they want to see if anything else critical was over-looked. cc me on a change if you like. Rob -- To post to this group, send an email to sage-devel@googlegroups.com To unsubscribe from this group, send an email to sage-devel+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/sage-devel URL: http://www.sagemath.org
