On Thu, 10 Jun 2010 08:20:58 +1200, François Bissey <f.r.bis...@massey.ac.nz> wrote: > I haven't tested your new spkg but I ran > sage -t -long devel/sage/sage/lib/singular/ > as you did in your ticket after removing everything that happens > after installing libsingular. My notes in my ebuild are saying: > --------------------------------------------------------------------------------------------- > The following is needed to get libfac.a libcf.a? libcfmem.a? > libsingcf_g.a? libsingfac.a? (the last 2 have some defects) > We should check that all these are really needed. > Then if needed check if we could build a specific target rather than > reconfiguring. > ------------------------------------------------------------------------------------------- > after removing those: > sage -t -long devel/sage/sage/libs/singular/ > <snip> > All tests passed! > Total time for all tests: 153.3 seconds > > I also tested > sage -t -long devel/sage/sage/interfaces/singular.py > <snip> > All tests passed! > Total time for all tests: 27.8 seconds > > So I think it could removed. It may have used at some point in time > but not any more.
I am not convinced that testing only libs/singular/ and interfaces/singular.py is sufficient to conclude this. Functionality from various parts of Singular is used all over the Sage library. I would be a bit more confident if a global "make testlong" was run, or at the very least if sage/rings and sage/schemes were tested. Best, Alex -- Alex Ghitza -- http://aghitza.org/ Lecturer in Mathematics -- The University of Melbourne -- Australia -- To post to this group, send an email to sage-devel@googlegroups.com To unsubscribe from this group, send an email to sage-devel+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/sage-devel URL: http://www.sagemath.org
