On Tue, Apr 13, 2010 at 11:28 AM, Jason Grout <jason-s...@creativetrax.com> wrote: > A while ago, some people pointed out the benefits of using something like > Rietveld [1] to do code review, which is a web-based code review tool that > allows people to comment (inline) on specific lines in a diff, I think > supports iterated patches, etc. > > I ran across ReviewBoard today [2] which seems to have similar features, and > may be more mature and doesn't rely on Google AppEngine. Does anyone have > experience with ReviewBoard? > > A nice video is here: http://blip.tv/file/827320 (though it's a bit old), > and apparently ReviewBoard supports mercurial and there are people working > on trac support. ReviewBoard supports reviews by annotating side-by-side > diffs (highlight a portion of the diff, then a box pops up for a comment), > iterated patches (with a display of the changes between versions of the > patches), etc. > > If someone has some time and wants to work on a code review tool, > ReviewBoard might be a tool to look at.
Thanks for posting about this. We definitely need to step up our code review system. I've started making a list of tickets that I care about in some way, and pinging relevant people to make sure they get reviewed. I've also been thinking of instituting a "karma system", where you get Karma for doing reviews. Moreover, people who submit a lot of code for inclusion and don't do reviews... will have the lowest priority for getting their code reviewed. -- William -- To post to this group, send an email to sage-devel@googlegroups.com To unsubscribe from this group, send an email to sage-devel+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/sage-devel URL: http://www.sagemath.org To unsubscribe, reply using "remove me" as the subject.
