On Apr 9, 5:53 pm, William Stein <wst...@gmail.com> wrote:
> On Thu, Apr 9, 2009 at 11:13 AM, davidloeffler <dave.loeff...@gmail.com>
> wrote:
<SNIP>
> Great. I've refereed this (positively). You fixed *numerous* bugs in
> the code, imho, when writing those 28 new doctests -- great work!
> Let's keep the doctest patches coming.
Yep, note that this fix for David's patch is a common issue:
202 sage: cmp(G, 1)
203 -1
202 sage: cmp(G, 1) in [1,-1]
203 True
cmp($FOO,$BAR) returns -1,0 or 1 depending on the memory address, so
the version that William did is much cleaner since G != 1 in this
case. A lot of those cmp() tests were set to random, but it is bad
style to do that.
> I'm mostly available on Saturday for a doctest day... so mark your calendars:
>
> SATURDAY, APRIL 11 -- Doctest Day.
+1 - someone might want to make an official wiki page for DocDay X and
send out an official announcement.
> -- William
Cheers,
Michael
--~--~---------~--~----~------------~-------~--~----~
To post to this group, send email to sage-devel@googlegroups.com
To unsubscribe from this group, send email to
sage-devel-unsubscr...@googlegroups.com
For more options, visit this group at http://groups.google.com/group/sage-devel
URLs: http://www.sagemath.org
-~----------~----~----~----~------~----~------~--~---
