On Nov 23, 2010, at 5:55 PM, Aaron Patterson wrote: > Can you rebase this one from master? It didn't apply cleanly for me.
I've rebased all remaining patches to master. I think these are fine: Allow registering javascript/stylesheet_expansions to existing symbols https://github.com/svenfuchs/rails/tree/master-asset_expansions_registration https://github.com/svenfuchs/rails/commit/514f8f46b2a5facc2fd9aaa31a393c114fbbbe75 Make TranslationHelper#translate use the :rescue_format option in I18n 0.5.0 https://github.com/svenfuchs/rails/tree/master-i18n-0.5.0-translation_helper https://github.com/svenfuchs/rails/commit/613f0a7ebf4ee93571aef95233ee71a3887ad3d8 Move 1.9 string interpolation syntax backport from I18n to ActiveSupport https://github.com/svenfuchs/rails/tree/master-backport-1_9-string-interpolation-syntax https://github.com/svenfuchs/rails/commit/0b4a6d6af31ab165115545ed894a15c0b702c38f This one still needs some thoughts though: Make polymorphic_url walk up the inheritance chain for given records https://github.com/svenfuchs/rails/tree/master-polymorphic_url-sti-fallbacks https://github.com/svenfuchs/rails/commit/56b0b5a3e1e31bb18ab005ff7f055c4b15a7bc43 See: https://github.com/svenfuchs/rails/commit/56b0b5a3e1e31bb18ab005ff7f055c4b15a7bc43#L0R135 and https://github.com/svenfuchs/rails/commit/56b0b5a3e1e31bb18ab005ff7f055c4b15a7bc43#L2R42 As you see I've just commented out these two linked lines. It seems this was introduced in https://github.com/rails/rails/commit/613cbe1f0075eed7ebf1ac521e99f652f6891330 I don't quite get that change, shouldn't self always respond to the generated named_route helper here? And if it doesn't, doesn't that indicate some flaw in a different layer? Maybe that's a discussion we should take off-list. I'll contact Piotr about this :) -- You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/rubyonrails-core?hl=en.
