On Tue, Nov 23, 2010 at 06:12:25PM +0100, Sven Fuchs wrote: > On Nov 23, 2010, at 5:55 PM, Aaron Patterson wrote: > > On Sun, Nov 21, 2010 at 11:13:20PM +0100, Sven Fuchs wrote: > >> https://rails.lighthouseapp.com/projects/8994/tickets/5969-bump-i18n-and-make-translationhelper-use-new-rescue_format-option#ticket-5969-8 > >> https://github.com/svenfuchs/rails/commit/a0f059618cb6eb46dfb97ef49004da776bf00d4c > >> With I18n 0.5.0 we'll ship some improvements to the exception api. This > >> patch makes the translation view helper leverage those improvements (by > >> not catching exceptions itself any more). > > > > Can you rebase this one from master? It didn't apply cleanly for me. > > Sure. Will do that tomorrow. > > >> https://rails.lighthouseapp.com/projects/8994/tickets/6013-move-19-string-interpolation-syntax-backport-from-i18n-to-activesupport > >> https://github.com/svenfuchs/rails/commit/85a05662fe7e0b06e9c7cd93cae9c3721058d879 > >> We've shipped a backport of 1.9 string interpolation syntax for quite some > >> versions in I18n. Now we're going to not use String#% anymore but > >> implement our own helper method for it. Meanwhile Rails (and probably > >> others) has started relying on this behavior and it seems appropriate to > >> move this to ActiveSupport (should probably have been done right from the > >> beginning). > > > > I'm still working on this. I'd like to get this patch in the backports > > gem. I'm not sure which is more appropriate, AS, or backports: > > > > https://github.com/marcandre/backports > > Oh, I didn't even know about that. Is this required by Rails though? At least > ActionPack relies on that String#% patch (routes behavior that uses the > %{foo} syntax, iirc) but doesn't seem to require the Backports gem? In that > case I'd guess it would need to go into ActiveSupport.
I think if AP was relying on behavior supplied by i18n, we should continue to use i18n for that support. I mean, we should switch it to use the new method in i18n. I'm only worried about end users that inadvertently used this backport. -- Aaron Patterson http://tenderlovemaking.com/
pgpRJhWuo6ci8.pgp
Description: PGP signature
