Hey. Really like your patch :) Quick feedback:
— we use i18n.* namespace for stuff like pluralization — maybe this is a better fit than support.*?.. — I'm not really sure about obj.respond_to?(:transliterate) — maybe we should do it pluralize-like and support lambdas as argument? As well as a Hash, of course. It's just that storing a lambda .rb translation is a bit easier than storing classes :) Also, I18n 0.3 has quite good lambda localization support already. Not really sure about performance issues and solving them this way, I believe stuff like this is handled by pluggable back-ends; I hope Sven or anyone else can correct me on that. On Thu, Apr 15, 2010 at 12:42 AM, Norman Clarke <[email protected]> wrote: > Hi all, > > The other day I sent a patch to Rails to improve > ActiveSupport::Inflector's support for transliterating UTF-8 Latin > characters to ASCII. > > In the discussion of the patch, I mentioned the idea of making > Inflector.transliterate use Rails' i18n facilities, and Jeremy Kemper > and Yaroslav Markin encouraged me to pursue the idea. > > > http://github.com/rails/rails/commit/dceef0828a23e8298dd9a9aab1a33c49e84f17d6#activesupport/lib/active_support/inflector/transliterate.rb-P50 > > I've been working on support for this and would like to ask for some > feedback before sending a patch to Rails. My work can be found at: > > http://github.com/norman/rails/tree/translit > > Basically the new code lets you do things like this: > > I18n.backend.store_translations(:de, :support => > {:transliterations => {"ü" => "ue", "ö" => "oe"}}) > assert_equal "Juergen Koehler", > ActiveSupport::Inflector.transliterate("Jürgen Köhler") > > Yaroslav, if you look in the tests you'll see I also basically stole > your Russian transliterator verbatim. :) > > One of my main concerns has been keeping reasonably good performance > in a thread-safe manner. The new code memoizes the available > transliterators in a class variable, which I'm a little hesitant about > doing, but I think will be ok. If someone more experienced with > thread-safety issues could advise me on that I'd be grateful. > > Regards, > > Norman > > -- Yaroslav http://evilmartians.com/ -- You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/rubyonrails-core?hl=en.
