Looks good to me overall, two suggestions though:
1. Four helper macros seems way too many, maybe just merge
`__scm_configure_git_common` to `__scm_init_git`?
2. Split the commit into two: one that only does the macro split and another
one that replaces `__scm_configure_git_am` with `%{nil}`
--
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/3472#issuecomment-2538980875
You are receiving this because you are subscribed to this thread.
Message ID: <rpm-software-management/rpm/pull/3472/c2538980...@github.com>
_______________________________________________
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
https://lists.rpm.org/mailman/listinfo/rpm-maint
