There are multiple git behaviors linked to valid user configuration; one among them is the --signoff flag and/or `format.signOff` configuration. Always setting the user to `rpm-build <rpm-build>` can then cause git to emit nonsense lines, which can not be easily turned off just for the affected repositories.
Setting the user only if one is not already configured should give best of both worlds – git will not bail out on unknown user and the actual author of commits will be kept in Signed-off-By trailers. --- I did not manage to run the test suite, so I'm hoping for CI to kick in. :crossed_fingers: You can view, comment on, or merge this pull request online at: https://github.com/rpm-software-management/rpm/pull/3472 -- Commit Summary -- * Only configure git user if needed -- File Changes -- M macros.in (4) -- Patch Links -- https://github.com/rpm-software-management/rpm/pull/3472.patch https://github.com/rpm-software-management/rpm/pull/3472.diff -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/3472 You are receiving this because you are subscribed to this thread. Message ID: <rpm-software-management/rpm/pull/3...@github.com>
_______________________________________________ Rpm-maint mailing list Rpm-maint@lists.rpm.org https://lists.rpm.org/mailman/listinfo/rpm-maint
