I've just re-read the discussion once more and realized that both me and
@pmatilai might have misunderstood the original use case that motivated this PR
in the first place:
It's *not* about `git am` overriding the author of the patch being applied -
that has always worked correctly (i.e. the actual author specified in the patch
file is used for the commit), regardless of what the git `user.name` and
`user.email` configuration is.
This PR is about the *manual* git workflow in a repository set up by
`%autopatch -S git[_am]` (i.e. after an `rpmbuild -bp`). When you make commits
in such a repository, *that* is where authorship is derived from your
configured (global or local) git user.
So, while it does cater to @khardix's workflow, I don't see a reason to only
skip user configuration for `git_am` specifically.
Thanks for the updated PR, it does fix the technicalities I pointed out
previously, but given the above, it might need a different approach. I'm just
not sure what it should be.
--
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/3472#issuecomment-2589603866
You are receiving this because you are subscribed to this thread.
Message ID: <rpm-software-management/rpm/pull/3472/c2589603...@github.com>
_______________________________________________
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
https://lists.rpm.org/mailman/listinfo/rpm-maint
