> > When `checkSep(EVR, '-', emsg)` or `checkSep(EVR, ':', emsg)` or
> > `checkEpoch(EVR, emsg)` returns RPMRC_FAIL, and
> > `_wrong_version_format_terminate_build` is defined as 0, the checkDep()
> > will returns RPMRC_OK and emsg is set.
>
> Oh, indeed. We could just remove _wrong_version_format_terminate_build, that
> has long since served its purpose, but then I spotted another case where this
> happens: the "it's not recommended to have..." warning messages.
>
> In both these cases a warning will get swallowed in case of an error, that's
> not a sane behavior even if the leak was fixed. This will need something
> rather different, please drop that particular commit from this series to let
> us move forward with the simpler cases. (that's always the gotcha with
> multiple unrelated commits in a PR: any one of them can stop the whole thing)
I agree with you that even if the leak is fixed, there are still other
problems, and I've deleted the corresponding submission,
--
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2293#issuecomment-1342559737
You are receiving this because you are subscribed to this thread.
Message ID: <rpm-software-management/rpm/pull/2293/c1342559...@github.com>
_______________________________________________
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint
