> Didn't look at the patches too closely yet, but:
>
> * Please capitalize commit messages properly, including the summary line. As
> in, start sentences with a capital letter.
> * Avoid piling on large number of commits to a single PR, it makes reviewing
> harder even if they're just tiny one-liners. Not every one-liner needs a
> separate PR and there's no hard line, but this is certainly at the upper
> limit already.
> * If something needs more than one or two frees, it needs a different
> approach entirely (eg the sbp leak here)
The leaked scenarios are different and independent. Is it clearer to submit and
fix a scenario separately?
--
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2293#issuecomment-1328695672
You are receiving this because you are subscribed to this thread.
Message ID: <rpm-software-management/rpm/pull/2293/c1328695...@github.com>
_______________________________________________
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint
