> The leaked scenarios are different and independent. Is it clearer to use
> every commit to fix every scenario separately?
The commits are fine as they are here. But as noted in
https://github.com/rpm-software-management/rpm/blob/master/CONTRIBUTING.md,
pull-requests should ideally be "atomic" too in that it should only be merged
as a whole or not at all. Here the common theme is "leaks" but the commits do
not depend on each other, so strictly speaking they don't belong to the same PR.
Now, that's not a hard rule, submitting 12 simple one-liners as separate PR's
"just because" gets tedious, but the more commits there are in a PR, the harder
it gets to review and like noted above, having one debatable commit in the lot
stalls the entire set from going forward.
--
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2293#issuecomment-1342436091
You are receiving this because you are subscribed to this thread.
Message ID: <rpm-software-management/rpm/pull/2293/c1342436...@github.com>
_______________________________________________
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint
