Github user davies commented on a diff in the pull request:

    https://github.com/apache/spark/pull/3003#discussion_r19636523
  
    --- Diff: core/src/main/scala/org/apache/spark/scheduler/TaskResult.scala 
---
    @@ -31,8 +31,8 @@ import org.apache.spark.util.Utils
     private[spark] sealed trait TaskResult[T]
     
     /** A reference to a DirectTaskResult that has been stored in the worker's 
BlockManager. */
    -private[spark]
    -case class IndirectTaskResult[T](blockId: BlockId) extends TaskResult[T] 
with Serializable
    +private[spark] case class IndirectTaskResult[T](blockId: BlockId, size: 
Int)
    --- End diff --
    
    There will be three lines after add `size: Int`. For consistency, it will 
also looks different than TaskResult.
    
    I think the basic idea behind break the line is that it can not fit in line.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to