Github user kayousterhout commented on a diff in the pull request:
https://github.com/apache/spark/pull/3003#discussion_r19636248
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/TaskResultGetter.scala ---
@@ -47,9 +49,18 @@ private[spark] class TaskResultGetter(sparkEnv:
SparkEnv, scheduler: TaskSchedul
getTaskResultExecutor.execute(new Runnable {
override def run(): Unit = Utils.logUncaughtExceptions {
try {
- val result =
serializer.get().deserialize[TaskResult[_]](serializedData) match {
- case directResult: DirectTaskResult[_] => directResult
- case IndirectTaskResult(blockId) =>
+ val (result, size) =
serializer.get().deserialize[TaskResult[_]](serializedData) match {
+ case directResult: DirectTaskResult[_] =>
+ if
(!taskSetManager.canFetchMoreResult(serializedData.limit())) {
+ throw new BigResultException
--- End diff --
Can you just abort the task set here, rather than throwing an exception? I
think it would make the code easier to read. Also, exceptions have gotten us
into trouble before where we don't catch them properly, especially when we
change the code late.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
