Github user mateiz commented on a diff in the pull request:

    https://github.com/apache/spark/pull/2311#discussion_r17951694
  
    --- Diff: 
yarn/common/src/main/scala/org/apache/spark/deploy/yarn/ApplicationMaster.scala 
---
    @@ -91,7 +94,11 @@ private[spark] class ApplicationMaster(args: 
ApplicationMasterArguments,
             if (sc != null) {
               logInfo("Invoking sc stop from shutdown hook")
               sc.stop()
    -          finish(FinalApplicationStatus.SUCCEEDED)
    +        }
    +
    +        // Shuts down the AM.
    +        if (!finished) {
    --- End diff --
    
    Our `saveAs*File` operations in Spark also avoid running if the output 
directly already exists, so there is that support in there. But for Spark I'd 
make this AM rerun configurable. The reason is that some Spark apps might be 
accessing weird data sources, serving a UI to outside users, or just doing 
fairly complicate logic inside that is hard to retry. These are things that MR 
jobs don't do as commonly.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to