Github user tgravescs commented on a diff in the pull request:

    https://github.com/apache/spark/pull/2311#discussion_r17940217
  
    --- Diff: 
yarn/common/src/main/scala/org/apache/spark/deploy/yarn/ApplicationMaster.scala 
---
    @@ -91,7 +94,11 @@ private[spark] class ApplicationMaster(args: 
ApplicationMasterArguments,
             if (sc != null) {
               logInfo("Invoking sc stop from shutdown hook")
               sc.stop()
    -          finish(FinalApplicationStatus.SUCCEEDED)
    +        }
    +
    +        // Shuts down the AM.
    +        if (!finished) {
    --- End diff --
    
    Yes the retry logic is for resubmitting the AM in the case it was on 
machine that went down, slow, network loss, etc..
    
    Ok so we'll go with if it System.exit(0) or returns 0 then it succeeded and 
everything else for now is failure and will retry if configured to retry.  If 
we don't want it to retry in certain cases we would need more information from 
the driver.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to