Github user mateiz commented on a diff in the pull request:

    https://github.com/apache/spark/pull/2311#discussion_r17930410
  
    --- Diff: 
yarn/common/src/main/scala/org/apache/spark/deploy/yarn/ApplicationMaster.scala 
---
    @@ -91,7 +94,11 @@ private[spark] class ApplicationMaster(args: 
ApplicationMasterArguments,
             if (sc != null) {
               logInfo("Invoking sc stop from shutdown hook")
               sc.stop()
    -          finish(FinalApplicationStatus.SUCCEEDED)
    +        }
    +
    +        // Shuts down the AM.
    +        if (!finished) {
    --- End diff --
    
    Just to understand, is the YARN retry logic there for resubmitting the AM? 
Most Spark applications don't support that, since their driver contains a lot 
of state. (Though I guess applications submitted in yarn-client mode might).
    
    In general, if the user's driver is running within the AM, I would say it's 
successful if the driver's main() returns 0 or calls System.exit(0). If the 
driver is running remotely, it should tell the AM when to shut down cleanly 
when it closes its SparkContext or exits.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to