cloud-fan commented on code in PR #54126: URL: https://github.com/apache/spark/pull/54126#discussion_r2838193509
########## sql/catalyst/src/main/java/org/apache/spark/sql/connector/catalog/GenerationExpression.java: ########## @@ -0,0 +1,97 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.spark.sql.connector.catalog; + +import java.util.Map; +import java.util.Objects; +import javax.annotation.Nullable; + +import org.apache.spark.SparkIllegalArgumentException; +import org.apache.spark.annotation.Evolving; +import org.apache.spark.sql.connector.expressions.Expression; + +/** + * A class that represents generation expressions for computed/generated columns. + * <p> + * Connectors can define generation expressions using either a SQL string (Spark SQL dialect) or an + * {@link Expression expression} if the generation expression can be expressed as a supported + * connector expression. If both the SQL string and the expression are provided, Spark first + * attempts to convert the given expression to its internal representation. If the expression + * cannot be converted, and a SQL string is provided, Spark will fall back to parsing the SQL + * string. + * + * @since 4.1.0 + */ +@Evolving +public class GenerationExpression { Review Comment: This is almost identical to `DefaultValue`? Shall we create a base class for them? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
