cloud-fan commented on code in PR #54126:
URL: https://github.com/apache/spark/pull/54126#discussion_r2838184337
##########
sql/catalyst/src/main/java/org/apache/spark/sql/connector/catalog/Column.java:
##########
@@ -123,7 +149,17 @@ static Column create(
* expression compatibility and reject writes as necessary.
*/
@Nullable
- String generationExpression();
+ default String generationExpression() {
+ return columnGenerationExpression() != null ?
columnGenerationExpression().getSql() : null;
+ }
+
+ /**
+ * Returns the generation expression of this table column as an {@link
GenerationExpression}
+ *
+ * @since 4.1.0
+ */
+ @Nullable
+ GenerationExpression columnGenerationExpression();
Review Comment:
is it a breaking change? existing impl can not compile anymore.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
