cloud-fan commented on code in PR #54126:
URL: https://github.com/apache/spark/pull/54126#discussion_r2838181841
##########
sql/catalyst/src/main/java/org/apache/spark/sql/connector/catalog/Column.java:
##########
@@ -67,13 +67,39 @@ static Column create(
null, null, metadataInJSON);
}
+ /**
+ * Creates a column with a generation expression in SQL string form.
+ *
+ * @since 4.1.0
+ * @deprecated Use
+ * {@link #create(String, DataType, boolean, String, GenerationExpression,
String)} instead.
+ */
+ @Deprecated
static Column create(
String name,
DataType dataType,
boolean nullable,
String comment,
String generationExpression,
String metadataInJSON) {
+ GenerationExpression genExpr = generationExpression != null
+ ? new GenerationExpression(generationExpression) : null;
+ return new ColumnImpl(name, dataType, nullable, comment, null,
+ genExpr, null, metadataInJSON);
+ }
+
+ /**
+ * Creates a column with a generation expression object.
+ *
+ * @since 4.1.0
Review Comment:
```suggestion
* @since 4.2.0
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
