pan3793 commented on code in PR #53840:
URL: https://github.com/apache/spark/pull/53840#discussion_r2831430259
##########
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/ExecutorPodsLifecycleManager.scala:
##########
@@ -75,6 +75,14 @@ private[spark] class ExecutorPodsLifecycleManager(
protected[spark] def getNumExecutorsFailed: Int =
failureTracker.numFailedExecutors
+ /**
+ * Register a pod creation failure. This increments the global executor
failure count
+ * which is checked against spark.executor.maxNumFailures.
+ */
+ protected[spark] def registerPodCreationFailure(): Unit = {
Review Comment:
the method name is not accurate then, how about
```suggestion
protected[spark] def registerExecutorFailure(): Unit = {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
