dongjoon-hyun commented on code in PR #53840:
URL: https://github.com/apache/spark/pull/53840#discussion_r2828702023
##########
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/AbstractPodsAllocator.scala:
##########
@@ -35,6 +35,20 @@ import org.apache.spark.resource.ResourceProfile
*/
@DeveloperApi
abstract class AbstractPodsAllocator {
+ /*
+ * Optional lifecycle manager for tracking executor pod lifecycle events.
+ * Set via setExecutorPodsLifecycleManager for backward compatibility.
+ */
+ protected var executorPodsLifecycleManager: ExecutorPodsLifecycleManager = _
Review Comment:
Like the comment, `Optional lifecycle manager`, we had better follow the
Scala style.
```scala
- protected var executorPodsLifecycleManager: ExecutorPodsLifecycleManager =
_
+ protected var executorPodsLifecycleManager:
Option[ExecutorPodsLifecycleManager] = None
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
