parthchandra commented on code in PR #53840:
URL: https://github.com/apache/spark/pull/53840#discussion_r2842137244
##########
resource-managers/kubernetes/core/src/test/scala/org/apache/spark/scheduler/cluster/k8s/ExecutorPodsAllocatorSuite.scala:
##########
@@ -1014,9 +1024,9 @@ class ExecutorPodsAllocatorSuite extends SparkFunSuite
with BeforeAndAfter {
assert(podsAllocatorUnderTest.invokePrivate(counter).get() === 0)
when(pvcResource.create()).thenThrow(new KubernetesClientException("PVC
fails to create"))
- intercept[KubernetesClientException] {
- podsAllocatorUnderTest.setTotalExpectedExecutors(Map(defaultProfile ->
1))
- }
+// intercept[KubernetesClientException] {
+// podsAllocatorUnderTest.setTotalExpectedExecutors(Map(defaultProfile ->
1))
+// }
Review Comment:
Oops. I had commented it out when experimenting with the propagation of the
exception thrown when pvc creation fails and accidentally left it in. Thank you
for catching it!!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
