cloud-fan commented on code in PR #50852:
URL: https://github.com/apache/spark/pull/50852#discussion_r2114083969
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/rules/RuleExecutor.scala:
##########
@@ -74,10 +83,19 @@ class PlanChangeLogger[TreeType <: TreeNode[_]] extends
Logging {
if (logBatches.isEmpty || logBatches.get.contains(batchName)) {
def message(): MessageWithContext = {
if (!oldPlan.fastEquals(newPlan)) {
+ val oldPlanStringWithOutput = oldPlan.treeString(verbose = false,
+ printOutputColumns = true)
+ val newPlanStringWithOutput = newPlan.treeString(verbose = false,
+ printOutputColumns = true)
+ // scalastyle:off line.size.limit
log"""
|=== Result of Batch ${MDC(BATCH_NAME, batchName)} ===
|${MDC(QUERY_PLAN, sideBySide(oldPlan.treeString,
newPlan.treeString).mkString("\n"))}
Review Comment:
What if we append the output info in the verbose treeString? Is the diff
readable?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
