HeartSaVioR commented on code in PR #50852:
URL: https://github.com/apache/spark/pull/50852#discussion_r2100337491
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/rules/RuleExecutor.scala:
##########
@@ -62,6 +62,9 @@ class PlanChangeLogger[TreeType <: TreeNode[_]] extends
Logging {
log"""
|=== Applying Rule ${MDC(RULE_NAME, ruleName)} ===
|${MDC(QUERY_PLAN, sideBySide(oldPlan.treeString,
newPlan.treeString).mkString("\n"))}
+ |
+ |Output Information:
+ |${MDC(QUERY_PLAN, newPlan.treeStringWithOutputColumns)}
Review Comment:
I think it's too long, verbose is not an optional param, so we need to
specify both `verbose` and `printOutputColumns`. I'm OK if the length does not
matter. Let me change it and revert if you see it be too long.
I'll make a change to do sideBySide here. Great suggestion!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
