HeartSaVioR commented on code in PR #50852:
URL: https://github.com/apache/spark/pull/50852#discussion_r2104195537
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/rules/RuleExecutor.scala:
##########
@@ -59,10 +59,15 @@ class PlanChangeLogger[TreeType <: TreeNode[_]] extends
Logging {
if (!newPlan.fastEquals(oldPlan)) {
if (logRules.isEmpty || logRules.get.contains(ruleName)) {
def message(): MessageWithContext = {
+ // scalastyle:off line.size.limit
log"""
|=== Applying Rule ${MDC(RULE_NAME, ruleName)} ===
|${MDC(QUERY_PLAN, sideBySide(oldPlan.treeString,
newPlan.treeString).mkString("\n"))}
+ |
+ |Output Information:
+ |${MDC(QUERY_PLAN, sideBySide(oldPlan.treeString(verbose = false,
printOutputColumns = true), newPlan.treeString(verbose = false,
printOutputColumns = true)))}
Review Comment:
Good point. Didn't realize the message() method itself is lazily evaluated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
