cloud-fan commented on code in PR #50594:
URL: https://github.com/apache/spark/pull/50594#discussion_r2075107637
##########
core/src/main/scala/org/apache/spark/util/UninterruptibleThread.scala:
##########
@@ -35,8 +35,38 @@ private[spark] class UninterruptibleThread(
this(null, name)
}
+ class UninterruptibleLock {
+ def awaitInterrupt(): Boolean = synchronized {
Review Comment:
It's not very intuitive to know the relationship between the boolean return
value and the function name. So returning true means keep waiting? shall we
name the function `shouldAwaitInterrupt`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
