vrozov commented on code in PR #50594:
URL: https://github.com/apache/spark/pull/50594#discussion_r2066781898
##########
core/src/main/scala/org/apache/spark/util/UninterruptibleThread.scala:
##########
@@ -92,11 +110,27 @@ private[spark] class UninterruptibleThread(
* interrupted until it enters into the interruptible status.
*/
override def interrupt(): Unit = {
- uninterruptibleLock.synchronized {
- if (uninterruptible) {
- shouldInterruptThread = true
+ if (uninterruptibleLock.synchronized {
Review Comment:
Neither synchronized blocks are very long. For example
https://github.com/apache/spark/blob/ef336ad51ba62e64a77896b9da12791051fa92cb/core/src/main/scala/org/apache/spark/ExecutorAllocationManager.scala#L773
is much longer.
I'll make the change if another revision is necessary.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
