vrozov commented on code in PR #50594:
URL: https://github.com/apache/spark/pull/50594#discussion_r2066768583
##########
core/src/main/scala/org/apache/spark/util/UninterruptibleThread.scala:
##########
@@ -69,10 +75,22 @@ private[spark] class UninterruptibleThread(
}
uninterruptibleLock.synchronized {
+ uninterruptible = true
+ }
+
+ while (uninterruptibleLock.synchronized {
// Clear the interrupted status if it's set.
shouldInterruptThread = Thread.interrupted() || shouldInterruptThread
- uninterruptible = true
+ // wait for super.interrupt() to be called
+ !shouldInterruptThread && awaitInterruptThread }) {
+ try {
+ Thread.sleep(100)
Review Comment:
As I said both `sleep()` and `await()` are functionally equivalent. At the
same time using `synchronized` on a `uninterruptibleLock` is a better option
here as the compiler provides guarantee that the monitor is released when the
control goes out of a synchronized block. With `ReentrantReadWriteLock` it is
necessary to add code that provides such guarantee for no added functionality.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
