vladimirg-db commented on code in PR #50436:
URL: https://github.com/apache/spark/pull/50436#discussion_r2039136459
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveDDLCommandStringTypes.scala:
##########
@@ -79,6 +83,8 @@ object ResolveDDLCommandStringTypes extends Rule[LogicalPlan]
{
// For CREATE TABLE, only v2 CREATE TABLE command is supported.
// Also, table DEFAULT COLLATION cannot be specified through CREATE TABLE
AS SELECT command.
case _: V2CreateTablePlan | _: ReplaceTable | _: CreateView | _:
AlterViewAs => true
+ // Check if view has default collation
+ case _ if AnalysisContext.get.collation.isDefined => true
Review Comment:
The naming is DDL specific (`isDDLCommand`, `isCreateOrAlterPlan`), but the
rule actually changes plans of queries over collated views as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
