Re: [PR] [SPARK-51646][SQL] Fix propagating collation in views with default collation [spark]

[via GitHub]

vladimirg-db commented on code in PR #50436:
URL: https://github.com/apache/spark/pull/50436#discussion_r2037535868


##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveDDLCommandStringTypes.scala:
##########
@@ -79,6 +83,8 @@ object ResolveDDLCommandStringTypes extends Rule[LogicalPlan] 
{
     // For CREATE TABLE, only v2 CREATE TABLE command is supported.
     // Also, table DEFAULT COLLATION cannot be specified through CREATE TABLE 
AS SELECT command.
     case _: V2CreateTablePlan | _: ReplaceTable | _: CreateView | _: 
AlterViewAs => true
+    // Check if view has default collation
+    case _ if AnalysisContext.get.collation.isDefined => true

Review Comment:
   I think this implementation is quite wrong, because now we match all the 
views from SELECT queries in `ResolveDDLCommandStringTypes`.
   
   
![image](https://github.com/user-attachments/assets/78edfb7f-96ec-46a0-a231-9212ad321a74)
   
![image](https://github.com/user-attachments/assets/a8fd9a21-77bb-4faa-913d-65d1a223f0eb)
   
![image](https://github.com/user-attachments/assets/8721d1a3-ac44-45ab-8ff4-10a3b7a9f7b6)
   
   @cloud-fan can we reconsider this implementation?
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org