MaxGekk commented on code in PR #50436:
URL: https://github.com/apache/spark/pull/50436#discussion_r2028437291
##########
sql/core/src/test/scala/org/apache/spark/sql/collation/DefaultCollationTestSuite.scala:
##########
@@ -410,6 +410,70 @@ class DefaultCollationTestSuiteV1 extends
DefaultCollationTestSuite {
// scalastyle:on
}
}
+ withView(testView) {
+ // scalastyle:off
+ sql(
+ s"""CREATE OR REPLACE VIEW $testView
+ | (c1)
+ | DEFAULT COLLATION sr_ai
+ | AS SELECT 'Ć' as c1 WHERE 'Ć' = 'C'
+ |""".stripMargin)
Review Comment:
Should 2 spaces indentation, please, tune your IDE. Also see
https://github.com/databricks/scala-style-guide?tab=readme-ov-file#indent
##########
sql/core/src/test/scala/org/apache/spark/sql/collation/DefaultCollationTestSuite.scala:
##########
@@ -410,6 +410,70 @@ class DefaultCollationTestSuiteV1 extends
DefaultCollationTestSuite {
// scalastyle:on
}
}
+ withView(testView) {
+ // scalastyle:off
+ sql(
+ s"""CREATE OR REPLACE VIEW $testView
+ | (c1)
+ | DEFAULT COLLATION sr_ai
+ | AS SELECT 'Ć' as c1 WHERE 'Ć' = 'C'
+ |""".stripMargin)
+ checkAnswer(sql(s"SELECT COUNT(*) FROM $testView WHERE c1 = 'Č'"),
Row(1))
+ // scalastyle:on
+ }
+ }
+
+ test("CREATE VIEW with DEFAULT COLLATION") {
+ withView(testView) {
+ sql(
+ s"""CREATE VIEW $testView DEFAULT COLLATION UTF8_LCASE
+ | as SELECT 'a' as c1
+ |""".stripMargin)
Review Comment:
ditto: indentation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
