anoopj commented on code in PR #50519:
URL: https://github.com/apache/spark/pull/50519#discussion_r2037861251
##########
sql/catalyst/src/main/java/org/apache/spark/sql/connector/catalog/TableInfo.java:
##########
@@ -77,8 +83,22 @@ public Builder withPartitions(Transform[] partitions) {
return this;
}
+ public Builder withConstraints(Constraint[] constraints) {
+ this.constraints = constraints;
+ return this;
+ }
+
public TableInfo build() {
checkNotNull(columns, "columns should not be null");
+ if (properties == null) {
Review Comment:
Moving to variable definitions SGTM
##########
sql/catalyst/src/main/java/org/apache/spark/sql/connector/catalog/TableInfo.java:
##########
@@ -29,6 +30,7 @@ public class TableInfo {
private final Column[] columns;
private final Map<String, String> properties;
private final Transform[] partitions;
+ private final Constraint[] constraints;
Review Comment:
+1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
