gengliangwang commented on code in PR #50519:
URL: https://github.com/apache/spark/pull/50519#discussion_r2036245187


##########
sql/catalyst/src/test/scala/org/apache/spark/sql/connector/catalog/InMemoryTableWithV2FilterCatalog.scala:
##########
@@ -43,4 +43,8 @@ class InMemoryTableWithV2FilterCatalog extends 
InMemoryTableCatalog {
     namespaces.putIfAbsent(ident.namespace.toList, Map())
     table
   }
+
+  override def createTable(ident: Identifier, tableInfo: TableInfo): Table = {
+    createTable(ident, tableInfo.columns(), tableInfo.partitions(), 
tableInfo.properties)

Review Comment:
   We should have a follow on unifying the create table overrides in tests:
   <img width="918" alt="image" 
src="https://github.com/user-attachments/assets/d2af0efc-cf24-4695-84ac-0fe500508b8d";
 />
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to