viirya commented on code in PR #50519:
URL: https://github.com/apache/spark/pull/50519#discussion_r2036251514
##########
sql/catalyst/src/test/scala/org/apache/spark/sql/connector/catalog/InMemoryTableWithV2FilterCatalog.scala:
##########
@@ -43,4 +43,8 @@ class InMemoryTableWithV2FilterCatalog extends
InMemoryTableCatalog {
namespaces.putIfAbsent(ident.namespace.toList, Map())
table
}
+
+ override def createTable(ident: Identifier, tableInfo: TableInfo): Table = {
+ createTable(ident, tableInfo.columns(), tableInfo.partitions(),
tableInfo.properties)
Review Comment:
Hmm, I saw you overrides `createTable(ident: Identifier, tableInfo:
TableInfo)` on `InMemoryTableCatalog` in this PR. It passes
`tableInfo.constraints()` when calling other `createTable`.
Why this `createTable(ident: Identifier, tableInfo: TableInfo)` doesn't need
to pass `constraints`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
