senthh commented on code in PR #50525: URL: https://github.com/apache/spark/pull/50525#discussion_r2031480480
########## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/timeExpressions.scala: ########## @@ -290,3 +290,61 @@ object HourExpressionBuilder extends ExpressionBuilder { } } } + +case class SecondsOfTime(child: Expression) + extends RuntimeReplaceable + with ExpectsInputTypes { + + override def replacement: Expression = StaticInvoke( + classOf[DateTimeUtils.type], + IntegerType, Review Comment: @vinodkc In jira, @MaxGekk has given just IntegerType seconds for example. So I thought the requirement is just to handle IntegerType. I can modify the implementation so that it should handle both with precision and without. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org