senthh commented on code in PR #50525: URL: https://github.com/apache/spark/pull/50525#discussion_r2033214441
########## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/timeExpressions.scala: ########## @@ -290,3 +290,61 @@ object HourExpressionBuilder extends ExpressionBuilder { } } } + +case class SecondsOfTime(child: Expression) + extends RuntimeReplaceable + with ExpectsInputTypes { + + override def replacement: Expression = StaticInvoke( + classOf[DateTimeUtils.type], + IntegerType, + "getSecondsOfTime", + Seq(child), + Seq(child.dataType) + ) + + override def inputTypes: Seq[AbstractDataType] = Seq(TimeType()) Review Comment: Now we are able to accept any precision of TimeType. Query: ``` spark.sql("select second(cast('12:00:01.123' as time(3)))").show(false) ``` output: ``` +-------------------------------------+ |second(CAST(12:00:01.123 AS TIME(3)))| +-------------------------------------+ |1 | +-------------------------------------+ ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org