senthh opened a new pull request, #50525:
URL: https://github.com/apache/spark/pull/50525
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines:
https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR:
https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g.,
'[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a
faster review.
7. If you want to add a new configuration, please read the guideline first
for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error type or message, please read the
guideline first in
'common/utils/src/main/resources/error/README.md'.
-->
### What changes were proposed in this pull request?
This PR adds support for extracting the hour component from TIME (TimeType)
values in Spark SQL.
scala> spark.sql("SELECT SECOND('13:59:59.999999');").show()
+----------------------------+
|second('13:59:59.999999)|
+----------------------------+
| 59|
+----------------------------+
scala> spark.sql("SELECT SECOND(TIME'13:59:59.99')").show()
+-------------------------+
|second(TIME'13:59:59.99')|
+-------------------------+
| 59|
+-------------------------+
### Why are the changes needed?
Spark previously supported second() for only TIMESTAMP type values. TIME
support was missing, leading to implicit casting attempt to TIMESTAMP, which
was incorrect. This PR ensures that hour(TIME'HH:MM:SS.######') behaves
correctly without unnecessary type coercion.
### Does this PR introduce _any_ user-facing change?
Yes
- Before this PR, calling second(TIME'HH:MM:SS.######') resulted in a
type mismatch error or an implicit cast attempt to TIMESTAMP, which was
incorrect.
- With this PR, second(TIME'HH:MM:SS.######') now works correctly for
TIME values without implicit casting.
- Users can now extract the second component from TIME values natively.
### How was this patch tested?
By running new tests:
```$ build/sbt "test:testOnly *TimeExpressionsSuite"```
### Was this patch authored or co-authored using generative AI tooling?
No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
