wengh commented on code in PR #50408:
URL: https://github.com/apache/spark/pull/50408#discussion_r2020404458
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/UserDefinedFunction.scala:
##########
@@ -86,6 +86,11 @@ object UserDefinedFunction {
// The default Hive Metastore SQL schema length for function resource uri.
private val HIVE_FUNCTION_RESOURCE_URI_LENGTH_THRESHOLD: Int = 4000
+ def parseRoutineParam(text: String, parser: ParserInterface): StructType = {
Review Comment:
parseTableSchema parses a colTypeList rather than a colDefinitionList.
colDefinition accepts options like DEFAULT and GENERATED ALWAYS AS but colType
doesn't
https://github.com/apache/spark/blob/e4eded884472a3c2b850dc9b5fb0c06d0946a7d0/sql/api/src/main/scala/org/apache/spark/sql/catalyst/parser/DataTypeAstBuilder.scala#L179-L193
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
