cloud-fan commented on code in PR #50408:
URL: https://github.com/apache/spark/pull/50408#discussion_r2017844351
##########
sql/api/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBaseParser.g4:
##########
@@ -177,6 +177,18 @@ singleTableSchema
: colTypeList EOF
;
+singleRoutineParamList
+ : routineParamList EOF
+ ;
+
+routineParamList
+ : routineParam (COMMA routineParam)*
+ ;
+
+routineParam
+ : colType defaultExpression?
Review Comment:
then how about we support the full col definition syntax and fail for those
we don't support as routine parameters? e.g. NOT NULL, GENERATED AS, etc.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
