cloud-fan commented on code in PR #50408: URL: https://github.com/apache/spark/pull/50408#discussion_r2022398644
########## sql/api/src/main/scala/org/apache/spark/sql/catalyst/parser/parsers.scala: ########## @@ -50,6 +50,10 @@ abstract class AbstractParser extends DataTypeParserInterface with Logging { astBuilder.visitSingleTableSchema(parser.singleTableSchema()) } + override def parseRoutineParam(sqlText: String): StructType = parse(sqlText) { parser => Review Comment: so the main difference between this and `parseTableSchema` is: it supports default expression, and it fails for unsupported fields. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org