senthh commented on code in PR #50355:
URL: https://github.com/apache/spark/pull/50355#discussion_r2009514857
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/timeExpressions.scala:
##########
@@ -233,3 +233,74 @@ object MinuteExpressionBuilder extends ExpressionBuilder {
}
}
}
+
+@ExpressionDescription(
Review Comment:
> Not sure what you meant. I have checked out your PR, and regenerated the
golden files:
>
> ```diff
> diff --git
a/sql/core/src/test/resources/sql-functions/sql-expression-schema.md
b/sql/core/src/test/resources/sql-functions/sql-expression-schema.md
> index 70853c3410f..9156a01349c 100644
> --- a/sql/core/src/test/resources/sql-functions/sql-expression-schema.md
> +++ b/sql/core/src/test/resources/sql-functions/sql-expression-schema.md
> @@ -159,7 +159,7 @@
> | org.apache.spark.sql.catalyst.expressions.Hex | hex | SELECT hex(17) |
struct<hex(17):string> |
> | org.apache.spark.sql.catalyst.expressions.HllSketchEstimate |
hll_sketch_estimate | SELECT hll_sketch_estimate(hll_sketch_agg(col)) FROM
VALUES (1), (1), (2), (2), (3) tab(col) |
struct<hll_sketch_estimate(hll_sketch_agg(col, 12)):bigint> |
> | org.apache.spark.sql.catalyst.expressions.HllUnion | hll_union | SELECT
hll_sketch_estimate(hll_union(hll_sketch_agg(col1), hll_sketch_agg(col2))) FROM
VALUES (1, 4), (1, 4), (2, 5), (2, 5), (3, 6) tab(col1, col2) |
struct<hll_sketch_estimate(hll_union(hll_sketch_agg(col1, 12),
hll_sketch_agg(col2, 12), false)):bigint> |
> -| org.apache.spark.sql.catalyst.expressions.Hour | hour | SELECT
hour('2009-07-30 12:58:59') | struct<hour(2009-07-30 12:58:59):int> |
> +| org.apache.spark.sql.catalyst.expressions.HourExpressionBuilder | hour
| SELECT hour('2018-02-14 12:58:59') | struct<hour(2018-02-14 12:58:59):int> |
> ```
>
> and the failed test passed:
>
> ```
> [info] ExpressionsSchemaSuite:
> ...
> [info] Passed: Total 0, Failed 0, Errors 0, Passed 0
> [info] No tests to run for hive / Test / testOnly
> [info] Run completed in 3 seconds, 403 milliseconds.
> [info] Total number of tests run: 1
> [info] Suites: completed 1, aborted 0
> [info] Tests: succeeded 1, failed 0, canceled 0, ignored 0, pending 0
> [info] All tests passed.
> ```
Thats great @MaxGekk .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
