MaxGekk commented on code in PR #50355:
URL: https://github.com/apache/spark/pull/50355#discussion_r2009482709
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/timeExpressions.scala:
##########
@@ -233,3 +233,74 @@ object MinuteExpressionBuilder extends ExpressionBuilder {
}
}
}
+
+@ExpressionDescription(
Review Comment:
> we should handle TIMETYPE in Hour expression itself rather than having
separate "HourExpressionBuilder" ?
Let's don't do that. Could you just regenerate the expected outputs of
`ExpressionsSchemaSuite`:
```
$ SPARK_GENERATE_GOLDEN_FILES=1 build/sbt "test:testOnly
*ExpressionsSchemaSuite"
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
