MaxGekk commented on code in PR #50269:
URL: https://github.com/apache/spark/pull/50269#discussion_r2008688974
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/timeExpressions.scala:
##########
@@ -160,3 +162,76 @@ object TryToTimeExpressionBuilder extends
ExpressionBuilder {
}
}
}
+
+// scalastyle:off line.size.limit
+@ExpressionDescription(
+ usage = "_FUNC_(hour, minute, second) - Create time from hour, minute and
second fields. For invalid inputs it will throw an error.",
+ arguments = """
+ Arguments:
+ * hour - the hour to represent, from 0 to 23
+ * minute - the minute to represent, from 0 to 59
+ * second - the second to represent, from 0 to 59.999999
+ """,
+ examples = """
+ Examples:
+ > SELECT _FUNC_(6, 30, 45.887);
+ 06:30:45.887
+ > SELECT _FUNC_(NULL, 30, 0);
+ NULL
+ """,
+ group = "datetime_funcs",
+ since = "4.1.0")
+// scalastyle:on line.size.limit
+case class MakeTime(
+ hours: Expression,
+ minutes: Expression,
+ secAndMicros: Expression)
+ extends TernaryExpression with ImplicitCastInputTypes with
SecAndNanosExtractor {
+ override def nullIntolerant: Boolean = true
+
+ override def first: Expression = hours
+ override def second: Expression = minutes
+ override def third: Expression = secAndMicros
+ override def inputTypes: Seq[AbstractDataType] = Seq(IntegerType,
IntegerType, DecimalType(16, 6))
+ override def dataType: DataType = TimeType(TimeType.MAX_PRECISION)
+ override def nullable: Boolean = children.exists(_.nullable)
+
+ override protected def nullSafeEval(hours: Any, minutes: Any, secAndMicros:
Any): Any = {
+ val (secs, nanos) = toSecondsAndNanos(secAndMicros.asInstanceOf[Decimal])
+
+ try {
+ val lt = LocalTime.of(
+ hours.asInstanceOf[Int],
+ minutes.asInstanceOf[Int],
+ secs,
+ nanos)
+ localTimeToMicros(lt)
+ } catch {
+ case e: DateTimeException =>
+ throw
QueryExecutionErrors.ansiDateTimeArgumentOutOfRangeWithoutSuggestion(e)
+ }
+ }
+
+ override def doGenCode(ctx: CodegenContext, ev: ExprCode): ExprCode = {
Review Comment:
Actually, I would prefer to avoid code duplication in codegen and in
non-codegen, and just use `StaticInvoke`. Could you create a helper function in
an object which takes 3 time components and returns micros, and just statically
call it from the `MakeTime` expression.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
