robreeves commented on code in PR #50269:
URL: https://github.com/apache/spark/pull/50269#discussion_r2033738910
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/timeExpressions.scala:
##########
@@ -290,3 +290,45 @@ object HourExpressionBuilder extends ExpressionBuilder {
}
}
}
+
+// scalastyle:off line.size.limit
+@ExpressionDescription(
+ usage = "_FUNC_(hour, minute, second) - Create time from hour, minute and
second fields. For invalid inputs it will throw an error.",
+ arguments = """
+ Arguments:
+ * hour - the hour to represent, from 0 to 23
+ * minute - the minute to represent, from 0 to 59
+ * second - the second to represent, from 0 to 59.999999
+ """,
+ examples = """
+ Examples:
+ > SELECT _FUNC_(6, 30, 45.887);
+ 06:30:45.887
+ > SELECT _FUNC_(NULL, 30, 0);
+ NULL
+ """,
+ group = "datetime_funcs",
+ since = "4.1.0")
+// scalastyle:on line.size.limit
+case class MakeTime(
+ hours: Expression,
+ minutes: Expression,
+ secsAndMicros: Expression)
+ extends RuntimeReplaceable with ExpectsInputTypes {
+
+ override def inputTypes: Seq[AbstractDataType] = Seq(IntegerType,
IntegerType, DecimalType(16, 6))
+ override def children: Seq[Expression] = Seq(hours, minutes, secsAndMicros)
+ override def dataType: DataType = TimeType(TimeType.MAX_PRECISION)
+ override def prettyName: String = "make_time"
+
+ override def replacement: Expression = StaticInvoke(
+ classOf[DateTimeUtils.type],
+ LongType,
Review Comment:
Fixed:
```scala
scala> spark.sql("select typeof(make_time(6, 30, 45.887))").first
val res1: org.apache.spark.sql.Row = [time(6)]
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
