MaxGekk commented on code in PR #50269:
URL: https://github.com/apache/spark/pull/50269#discussion_r2002870806


##########
common/utils/src/main/resources/error/error-conditions.json:
##########
@@ -1188,6 +1188,12 @@
     ],
     "sqlState" : "22023"
   },
+  "DATETIME_FIELD_OUT_OF_BOUNDS_ANSI_ONLY" : {

Review Comment:
   Could you create two sub-classes of `DATETIME_FIELD_OUT_OF_BOUNDS` like:
   ```
       "subClass" : {
         "WITHOUT_SUGGESTION" : {
           "message" : [
             ""
           ]
         },
         "WITH_SUGGESTION" : {
           "message" : [
             "If necessary set <ansiConfig> to \"false\" to bypass this error."
           ]
         }
       },
   ```
   see for instance:
   
https://github.com/apache/spark/blob/35e0e08acab1539f9984d1dbabe691fee07fbd98/common/utils/src/main/resources/error/error-conditions.json#L5530
   
https://github.com/apache/spark/blob/35e0e08acab1539f9984d1dbabe691fee07fbd98/common/utils/src/main/resources/error/error-conditions.json#L4246
   
https://github.com/apache/spark/blob/35e0e08acab1539f9984d1dbabe691fee07fbd98/common/utils/src/main/resources/error/error-conditions.json#L5318



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to