beliefer commented on code in PR #50209:
URL: https://github.com/apache/spark/pull/50209#discussion_r1985959471
##########
core/src/main/scala/org/apache/spark/deploy/worker/Worker.scala:
##########
@@ -403,7 +403,7 @@ private[deploy] class Worker(
// We have exceeded the initial registration retry threshold
// All retries from now on should use a higher interval
if (connectionAttemptCount == INITIAL_REGISTRATION_RETRIES) {
- registrationRetryTimer.foreach(_.cancel(true))
+ registrationRetryTimer.foreach(_.cancel(false))
registrationRetryTimer = Some(
Review Comment:
```
registrationRetryTimer = Some(
forwardMessageScheduler.scheduleAtFixedRate(
() => Utils.tryLogNonFatalError {
self.send(ReregisterWithMaster) },
PROLONGED_REGISTRATION_RETRY_INTERVAL_SECONDS,
PROLONGED_REGISTRATION_RETRY_INTERVAL_SECONDS,
TimeUnit.SECONDS))
```
##########
core/src/main/scala/org/apache/spark/deploy/worker/Worker.scala:
##########
@@ -403,7 +403,7 @@ private[deploy] class Worker(
// We have exceeded the initial registration retry threshold
// All retries from now on should use a higher interval
if (connectionAttemptCount == INITIAL_REGISTRATION_RETRIES) {
- registrationRetryTimer.foreach(_.cancel(true))
+ registrationRetryTimer.foreach(_.cancel(false))
registrationRetryTimer = Some(
Review Comment:
```
registrationRetryTimer = Some(
forwardMessageScheduler.scheduleAtFixedRate(
() => Utils.tryLogNonFatalError {
self.send(ReregisterWithMaster) },
PROLONGED_REGISTRATION_RETRY_INTERVAL_SECONDS,
PROLONGED_REGISTRATION_RETRY_INTERVAL_SECONDS,
TimeUnit.SECONDS))
```
ditto
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
