beliefer commented on code in PR #50209:
URL: https://github.com/apache/spark/pull/50209#discussion_r1985957890
##########
core/src/main/scala/org/apache/spark/deploy/client/StandaloneAppClient.scala:
##########
@@ -277,7 +277,7 @@ private[spark] class StandaloneAppClient(
override def onStop(): Unit = {
if (registrationRetryTimer.get != null) {
- registrationRetryTimer.get.cancel(true)
+ registrationRetryTimer.get.cancel(false)
Review Comment:
```
registrationRetryTimer.set(registrationRetryThread.schedule(new
Runnable {
override def run(): Unit = {
if (registered.get) {
registerMasterFutures.get.foreach(_.cancel(true))
registerMasterThreadPool.shutdownNow()
} else if (nthRetry >= REGISTRATION_RETRIES) {
markDead("All masters are unresponsive! Giving up.")
} else {
registerMasterFutures.get.foreach(_.cancel(true))
registerWithMaster(nthRetry + 1)
}
}
}, REGISTRATION_TIMEOUT_SECONDS, TimeUnit.SECONDS))
```
There is no method called in the task that will throw `InterruptdEException`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
