beliefer commented on code in PR #50209: URL: https://github.com/apache/spark/pull/50209#discussion_r1986202471
########## connector/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/consumer/FetchedDataPool.scala: ########## @@ -139,7 +139,7 @@ private[consumer] class FetchedDataPool( } def reset(): Unit = synchronized { - scheduled.foreach(_.cancel(true)) + scheduled.foreach(_.cancel(false)) Review Comment: This PR want avoid the overhead of the invalid thread interruption. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org